https://bugzilla.redhat.com/show_bug.cgi?id=1086378 --- Comment #2 from Colin Walters <walters@xxxxxxxxxx> --- There's some bits in this spec file that I'm not sure are necessary, e.g.: %global __os_install_post %{_rpmconfigdir}/brp-compress # btrfs not available for rhel yet As for: %description %{summary} Now for a lot of shared libraries I think this is fine, but this package probably merits a bit of an attempt at a description =) Just take the upstream "A client and daemon for installing and linking Docker containers into systemd across hosts" ? Can also just drop: %if 0%{?rhel} #%patch0 -p1 -b ignore-btrfs-for-rhel #%patch90 -p1 -b docker-0.9-el6-lxc %endif #%patch1 -p1 -b upstream-patched-archive-tar And drop: %pre %post %preun %postun Theoretically we should use %systemd_postun and such right? <lsm5@xxxxxxxxxx Missing a trailing > -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review