[Bug 1086664] Review Request: rubygem-actionview - Rendering framework putting the V in MVC (part of Rails)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1086664



--- Comment #2 from Vít Ondruch <vondruch@xxxxxxxxxx> ---
* Test suite
  - I would suggest to expand the test suite in %check section (see activemodel
    for example).
  - If you don't like the %check section, then you should move it into the
%prep
    section, though there are no directories prepared yet, so it would be
weird.
    %build section is definitely wrong place.

* %{bootstrap} macro
  - Be sure to don't forget to re-enable the bootstrap macro.
  - Actually, I am not sure why you suggest updated activesupport, but you are
    not mentioning actionpack and activerecord, which are listed as BR of this
    package. It doesn't look I can test the package without them.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]