https://bugzilla.redhat.com/show_bug.cgi?id=1082515 --- Comment #5 from Jens Petersen <petersen@xxxxxxxxxx> --- Thank you for reviewing > Can you change the %define here to %global: > %define cabal_configure_options --enable-tests Okay but this is only used locally in the %build section so I intentionally used %define to make it local, but this may still be frowned upon perhaps? Is %define only acceptable inside macro definitions? > Can we ask upstream to add a manpage to their next release? Sure: https://github.com/ndmitchell/shake/issues/106 Not sure if/when it might happen though. > And this should be pretty easy I think to fix on import: > shake.src: W: strange-permission shake-0.11.4.tar.gz 0600L Not sure why this time: anyway it will "dissolve" during the srpm import. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review