[Bug 1085612] Review Request: minetest-classic - Fork of Minetest, a multiplayer infinite-world block sandbox with survival mode

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1085612



--- Comment #1 from Michael Schwendt <bugs.michael@xxxxxxx> ---
> http://copr-be.cloud.fedoraproject.org/results/mavjs/minetest-classic/fedora-20-x86_64/minetest-classic-1403.00-1.fc20/build.log

Build output is non-verbose. One cannot verify the compiler settings that are
used (e.g. compiler flags, preprocessor definitions, paths).
https://fedoraproject.org/wiki/Packaging:Guidelines#Compiler_flags


> #warning "Disabling unit tests"

Any comment on this?


> warning: File listed twice: /usr/local/share/locale/da/LC_MESSAGES/minetest-classic.mo
> warning: File listed twice: /usr/local/share/locale/de/LC_MESSAGES/minetest-classic.mo
> warning: File listed twice: /usr/local/share/locale/fr/LC_MESSAGES/minetest-classic.mo
> warning: File listed twice: /usr/local/share/locale/it/LC_MESSAGES/minetest-classic.mo

Reason to worry, because /usr/local must not be used by the package.


> cp -p %{buildroot}%{_prefix}/local/bin/%{name} %{buildroot}%{_bindir}

> *** WARNING: identical binaries are copied, not linked:
>         /usr/bin/minetest-classic
>    and  /usr/local/bin/minetest-classic

/usr/local must not be used by Fedora's packages.

Have you ever before listed the package's files?

$ rpmls -p minetest-classic-1403.00-1.fc20.x86_64.rpm |grep /usr/local|wc -l
426


Please point the fedora-review tool at this ticket. It evaluates the "SRPM
URL:" and "Spec URL:" lines and performs many helpful checks. Run
"fedora-review -b 1085612".

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]