https://bugzilla.redhat.com/show_bug.cgi?id=1084776 --- Comment #2 from Mohamed El Morabity <pikachu.2014@xxxxxxxxx> --- The package looks quite good at first sight. Just one note about the release tag: according to the guidelines, it should be: 0.7.git%{shortcommit}%{?dist} (see https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Pre-Release_packages). These same guidelines recommend adding the commit date to the prerelease tag too: 0.7.2014XXXXgit%{shortcommit}(see https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Non-Numeric_Version_in_Release). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review