https://bugzilla.redhat.com/show_bug.cgi?id=1079751 David Dick <ddick@xxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |psabata@xxxxxxxxxx --- Comment #3 from David Dick <ddick@xxxxxxxx> --- Hi Sven, Congrats and welcome to fedora! The following things need to get fixed in this package FIX: Licensing. Given that DateCalc.h, DateCalc.c and ToolBox.h are only licensed under the LGPLv2+ and the rest of the package is "GPL+ or Artistic", i would suggest the License entry should be "LGPLv2+ and GPL+ or Artistic". Petr? Any comments? BR: perl(strict) # line 13 of Makefile.PL BR: perl(vars) # line 16 of lib/Date/Calc/XS.pm BR: perl(Date::Calc::Object) # line 10 of t/m011.t BR: perl(Exporter) # line 20 of lib/Date/Calc/XS.pm BR: perl(DynaLoader) # line 21 of lib/Date/Calc/XS.pm BR: perl(bytes) # line 3 of t/f029.t BR: perl(Date::Calendar) # line 16 of t/m009.t (packaged as part of perl-Date-Calc) BR: perl(Date::Calendar::Profiles) # line 15 of t/m009.t (also part of perl-Date-Calc) BR: perl(Bit::Vector) # line 7 of t/m009.t BR: perl(Date::Calendar::Year) # line 129 of t/f000.t (part of perl-Date-Calc) BR: perl(Config) # line 20 of Makefile.PL Your changelog entries need to be either resolved into one entry per release (fine with me) or each individual entry should get a new release number The following things should be fixed; TODO: The following versions are specified in Makefile.PL. However, they may restrict you if you want to do older builds (<= EPEL6/F19). If you can want to build for older versions, we can discuss these requirements. BR: perl(Carp::Clan) >= 6.01 BR: perl(Bit::Vector) >= 7.1 BR: perl(Date::Calc) >= 6.3 To fix rpmlint complaints, include the following line; find $RPM_BUILD_ROOT -type f -name '*.bs' -size 0 -exec rm -f {} \; following find $RPM_BUILD_ROOT -type f -name .packlist -exec rm -f {} \; Replace the various %doc lines with %doc CHANGES.txt README.txt CREDITS.txt license Replace Source0 (by author) with Source0: http://www.cpan.org/modules/by-module/Date/Date-Calc-XS-%{version}.tar.gz This will protect you if the author changes. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review