[Bug 1084021] Review Request: openjpeg2 - C-Library for JPEG 2000

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1084021



--- Comment #5 from Sandro Mani <manisandro@xxxxxxxxx> ---
Thanks for the review, I've fixed all the issues you pointed out, but while
doing so I came across some additional points:

- cmake does not seem to pick up the CFLAGS exported by %cmake: If I build with
-DCMAKE_BUILD_TYPE=Release, the compile flags are "-ffast-math -O3 -DNDEBUG
-fPIC" where "-ffast-math" is explicitly added in the openjpeg CMakeLists.txt.
What is the best way to get cmake to honour the CFLAGS env?

- Rex, do you have any suggestions as to whether the optional components should
be built? (MJ2, JPWL, JPIP, JPIP_SERVER, JP3D, Java bindings). I see you didn't
build them in the 1.x package.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]