https://bugzilla.redhat.com/show_bug.cgi?id=1084397 Pavel Alexeev (aka Pahan-Hubbitus) <pahan@xxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@xxxxxxxxxxxxxxxxx |pahan@xxxxxxxxxxxxx Flags| |fedora-review? --- Comment #14 from Pavel Alexeev (aka Pahan-Hubbitus) <pahan@xxxxxxxxxxxxx> --- >You can built jdns library against Qt5 and it will be worked. But package built against Qt4. May it then be used to be linked with Qt5 application? If no, may be have worth provide two versions out of the box? Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues: ======= - Package uses either %{buildroot} or $RPM_BUILD_ROOT Note: Using both %{buildroot} and $RPM_BUILD_ROOT See: http://fedoraproject.org/wiki/Packaging/Guidelines#macros - "Package does not own files or directories owned by other packages", "Package does not contain duplicates in %files". %{_bindir}/jdns used in main package and -bin subpackage [!]: Package does not generate any conflict. See comments before about twice binarie included. - Please include README.md in %doc - Honestly I do not see worth to split that small package on so much subpackages. I suggest include binary in main package and drop -bin subpackage completely. Also even main package requires libQtCore.so.4() (splitting to minimize dependency may be some justification), so qjdns also seems redundant. - Requires: qt4%{?_isa} seems redundant as it pulled automatically. ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "MIT/X11 (BSD like)". [x]: License file installed when any subpackage combination is installed. [x]: Package must own all directories that it creates. [!]: Package does not own files or directories owned by other packages. %{_bindir}/jdns used in main package and -bin [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [!]: Package does not generate any conflict. See comments before about twice binarie included. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6718749 http://koji.fedoraproject.org/koji/taskinfo?taskID=6718812 [!]: Package installs properly. Packages can't be installed separate: $ LANG=C sudo rpm -Uhv jdns-2.0.0-2.fc20.x86_64.rpm jdns-bin-2.0.0-2.fc20.x86_64.rpm error: Failed dependencies: libqjdns.so.2()(64bit) is needed by jdns-2.0.0-2.fc20.x86_64 libqjdns.so.2()(64bit) is needed by jdns-bin-2.0.0-2.fc20.x86_64 qjdns(x86-64) = 2.0.0-2.fc20 is needed by jdns-bin-2.0.0-2.fc20.x86_64 [x]: Rpmlint is run on all rpms the build produces. Rpmlint ------- Checking: jdns-2.0.0-2.fc20.x86_64.rpm qjdns-2.0.0-2.fc20.x86_64.rpm jdns-bin-2.0.0-2.fc20.x86_64.rpm jdns-devel-2.0.0-2.fc20.x86_64.rpm jdns-2.0.0-2.fc20.src.rpm jdns.x86_64: W: spelling-error %description -l en_US Multicast -> Multics, Simulcast jdns.x86_64: W: spelling-error %description -l en_US mdnsd -> mdse jdns.x86_64: W: obsolete-not-provided qjdns jdns.x86_64: W: obsolete-not-provided qjdns-devel jdns.x86_64: W: no-manual-page-for-binary jdns qjdns.x86_64: W: spelling-error Summary(en_US) jdns -> jeans qjdns.x86_64: W: spelling-error %description -l en_US Multicast -> Multics, Simulcast qjdns.x86_64: W: spelling-error %description -l en_US mdnsd -> mdse qjdns.x86_64: W: no-documentation jdns-bin.x86_64: W: spelling-error %description -l en_US Multicast -> Multics, Simulcast jdns-bin.x86_64: W: spelling-error %description -l en_US mdnsd -> mdse jdns-bin.x86_64: W: no-documentation jdns-bin.x86_64: W: no-manual-page-for-binary jdns jdns-devel.x86_64: W: spelling-error %description -l en_US Multicast -> Multics, Simulcast jdns-devel.x86_64: W: spelling-error %description -l en_US mdnsd -> mdse jdns-devel.x86_64: W: no-documentation jdns.src: W: spelling-error %description -l en_US Multicast -> Multics, Simulcast jdns.src: W: spelling-error %description -l en_US mdnsd -> mdse 5 packages and 0 specfiles checked; 0 errors, 18 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint jdns-bin qjdns jdns-devel jdns jdns-bin.x86_64: W: spelling-error %description -l en_US Multicast -> Multics, Simulcast jdns-bin.x86_64: W: spelling-error %description -l en_US mdnsd -> mdse jdns-bin.x86_64: W: no-documentation jdns-bin.x86_64: W: no-manual-page-for-binary jdns qjdns.x86_64: W: spelling-error Summary(en_US) jdns -> jeans qjdns.x86_64: W: spelling-error %description -l en_US Multicast -> Multics, Simulcast qjdns.x86_64: W: spelling-error %description -l en_US mdnsd -> mdse qjdns.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libqjdns.so.2.0.0 /lib64/libm.so.6 qjdns.x86_64: W: no-documentation jdns-devel.x86_64: W: spelling-error %description -l en_US Multicast -> Multics, Simulcast jdns-devel.x86_64: W: spelling-error %description -l en_US mdnsd -> mdse jdns-devel.x86_64: W: no-documentation jdns.x86_64: W: spelling-error %description -l en_US Multicast -> Multics, Simulcast jdns.x86_64: W: spelling-error %description -l en_US mdnsd -> mdse jdns.x86_64: W: obsolete-not-provided qjdns jdns.x86_64: W: obsolete-not-provided qjdns-devel jdns.x86_64: W: no-manual-page-for-binary jdns 4 packages and 0 specfiles checked; 0 errors, 17 warnings. # echo 'rpmlint-done:' [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist Name take coordinated. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. ===== SHOULD items ===== Generic: [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [-]: Final provides and requires are sane (see attachments). [?]: Package functions as described. Can't test until other issues resolved. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Scriptlets must be sane, if used. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: %check is present and all tests pass. [-]: Packages should try to preserve timestamps of original installed files. [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Uses parallel make %{?_smp_mflags} macro. [x]: The placement of pkgconfig(.pc) files are correct. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [-]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Test run failed [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Requires -------- jdns-bin (rpmlib, GLIBC filtered): libQtCore.so.4()(64bit) libQtNetwork.so.4()(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libjdns.so.2()(64bit) libm.so.6()(64bit) libqjdns.so.2()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) qjdns(x86-64) rtld(GNU_HASH) qjdns (rpmlib, GLIBC filtered): /sbin/ldconfig jdns(x86-64) libQtCore.so.4()(64bit) libQtNetwork.so.4()(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libjdns.so.2()(64bit) libm.so.6()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) qt4(x86-64) rtld(GNU_HASH) jdns-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config jdns(x86-64) libjdns.so.2()(64bit) libqjdns.so.2()(64bit) pkgconfig(QtCore) pkgconfig(QtNetwork) pkgconfig(jdns) jdns (rpmlib, GLIBC filtered): /sbin/ldconfig libQtCore.so.4()(64bit) libQtNetwork.so.4()(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libjdns.so.2()(64bit) libm.so.6()(64bit) libqjdns.so.2()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) rtld(GNU_HASH) Provides -------- jdns-bin: jdns-bin jdns-bin(x86-64) qjdns: libqjdns.so.2()(64bit) qjdns qjdns(x86-64) jdns-devel: jdns-devel jdns-devel(x86-64) pkgconfig(jdns) pkgconfig(qjdns) jdns: jdns jdns(x86-64) libjdns.so.2()(64bit) Source checksums ---------------- http://delta.affinix.com/download/jdns-2.0.0.tar.bz2 : CHECKSUM(SHA256) this package : 8d94ba519dc18eb2ebbfecac3f211150e692892c695061471ae34f876d96adf6 CHECKSUM(SHA256) upstream package : 8d94ba519dc18eb2ebbfecac3f211150e692892c695061471ae34f876d96adf6 Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13 Command line :/usr/bin/fedora-review -b 1084397 Buildroot used: fedora-20-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review