[Bug 1078588] Review Request: ts - Task Spooler

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1078588



--- Comment #6 from Michael Schwendt <bugs.michael@xxxxxxx> ---
> License:	GPLv2+

Where does it say "GPLv2 or later"?

 
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#.22or_later_version.22_licenses

The file "COPYING" is "License: GPLv2", and the source files don't tell "or
later":

 *
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Clarification

 * https://www.gnu.org/licenses/gpl-faq.html#NoticeInSourceFile


> %clean
> rm -rf $RPM_BUILD_ROOT

same as comment 2


> %doc %{_datadir}/ts/*

https://fedoraproject.org/wiki/Packaging:Guidelines#File_and_Directory_Ownership
 -> https://fedoraproject.org/wiki/Packaging:UnownedDirectories


> %build
> make %{?_smp_mflags}

https://fedoraproject.org/wiki/Packaging:Guidelines#Compiler_flags

In particular, it will be a small exercise to figure out whether you can use a
trick such as

  %configure || :
  make %{?_smp_mflags}

to reuse the flags exported by the %configure macro (see rpm -E %configure), or
whether it will be necessary to activate the flags via a different way (e.g. by
patching the Makefile).


* fedora-review also says:

[!]: Sources can be downloaded from URI in Source: tag
     Note: Could not download Source0:
     http://viric.name/soft/ts/ts-0.7.4.tar.gz
     See: http://fedoraproject.org/wiki/Packaging:Guidelines#Tags

ts.x86_64: W: invalid-url URL: http://viric.name/soft/ts/ <urlopen error [Errno
-2] Name or service not known>


> ts.x86_64: E: incorrect-fsf-address /usr/share/ts/COPYING

https://fedoraproject.org/wiki/Common_Rpmlint_issues#incorrect-fsf-address

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]