https://bugzilla.redhat.com/show_bug.cgi?id=1083941 --- Comment #6 from Antonio Trande <anto.trande@xxxxxxxxx> --- (In reply to Han Frederic from comment #4) 1. ------------------------------------------------------------------- > For 4. I put comments in giac.spec. (did you want them in the description > field?) No. Here, with "explicit", I meant putting all executables under '%files' section: %{_bindir}/icas %{_bindir}/giac %{_bindir}/xcas %{_bindir}/pgiac Rather, you may split in more sub-packages further. See file that I attached. 2. ------------------------------------------------------ > > For 5. The licence info was in the README so I put a link, but some parts > were old and I asked for a refresh. So I patch the README with the > giac-1.1.1 README. I think it's no so simple. We need complete license files. See http://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text Talk about with upstream. Quoting README file: >The giac library and the xcas program are released under the GPL license, >version 3 or above, as published by the Free Software Foundation, >... >The on-line help is included in xcas and giac/cas. The resposible >file is doc/aide_cas. It is released under the GPL version 2 or above >and is copyrighted by R. de Graeve, B. Parisse and M. Lopez de la Fuente. Both these licenses are compatible. Main package must to have 'GPLv3+' License tag; -doc subpackage the 'GPLv2+" instead. There is also documentation no compiled. See INSTALL file. 3. ----------------------------------------------------- Files above are needed at runtime and the directories which contain them are owned by -doc sub-package; -doc subpackage requires main package. That's fine. Both packages could also co-own those directories which contain the files needed at runtime (see http://fedoraproject.org/wiki/Packaging:Guidelines#The_directory_is_owned_by_a_package_which_is_not_required_for_your_package_to_function) but, since GUI will use all documentation files if called by its Help menu, 'giac-doc' sub-package must requires 'giac' (like so happens for 'giac-devel'). In fine, giac/doc/ directory is entirely owned by 'giac-doc' that *must* be installed together with 'giac'. See file attached. 4. ----------------------------------------------------- > > For 6. The english html doc is good. (about 1700 files and 12Mo) but the > french one was 6 times more. > I'am trying to provide some minimal man pages, is there some fedora script > that I should use to install man pages? Not one in particular. As you see, I've just installed them then build system will "gzip" manpage files. 5. ----------------------------------------------------- > > For 8. This make check won't work for an automatic build, the outputs are > too old. > And in newest release? 6. ---------------------------------------------------- Please, update %Changelog section when change the SPEC file. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review