https://bugzilla.redhat.com/show_bug.cgi?id=1084007 Parag AN(पराग) <panemade@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review? --- Comment #1 from Parag AN(पराग) <panemade@xxxxxxxxx> --- Issues: 1) It's better to use subpackage name -common and not -license. See http://fedoraproject.org/wiki/Fonts_spec_template_for_multiple_fonts suggests using -common for common files needed by all other packages. 2) Requires: fontpackages-filesystem is missing for -condensed-fonts subpackage. The other simple way is to add it to -common and let -common be required by google-roboto-fonts and google-roboto-condensed-fonts. This way -common will provide LICENSE.txt file and you can also add RobotoSpecimenBook.pdf as a %doc If you add -common then let it alone Requires: fontpackages-filesystem 3) Group tag is no longer needed. 4) Summary can be "Google Roboto fonts" -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review