https://bugzilla.redhat.com/show_bug.cgi?id=1083962 Paulo Andrade <paulo.cesar.pereira.de.andrade@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paulo.cesar.pereira.de.andr | |ade@xxxxxxxxx --- Comment #8 from Paulo Andrade <paulo.cesar.pereira.de.andrade@xxxxxxxxx> --- On a quick look, I can say that I do not like when one does not run a proper "make install" in %install, this can easily break in subtle ways, if not in the first spec write, whenever the package is updated. I see the Makefile at least appears to respect $DESTDIR for the install target. You should run "make testall" in %check and give good reasons if it does not work. This way both you and reviewer will at least have a good hint the package is functional if it pass %check. Please post a link to the failed arm build, to have an idea of why it fails. I suggest renaming the patches to maxscale-xyz.patch, and use "PatchN: %{name}-xyz.patch", but this is a cosmetic change, just a common pattern in fedora packages. Instead of using CFLAGS="%{optflags} -fpie" you should use https://fedoraproject.org/wiki/Packaging:Guidelines#PIE that automatically does it for you; could then just need to force CFLAGS="%{optflags} and LDFLAGS="%{__global_ldflags}" But I am not sure if it is handled the same way for rhel. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review