https://bugzilla.redhat.com/show_bug.cgi?id=1083941 --- Comment #3 from Antonio Trande <anto.trande@xxxxxxxxx> --- Okay, we can go on. 1. 'rm -rf $RPM_BUILD_ROOT' '%clean' section all file permission settings (%defattr..) are not necessary anymore. See http://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions http://fedoraproject.org/wiki/Packaging:Guidelines#.25clean 2. No mix $RPM_BUILD_ROOT and %{buildroot}; use just one of them. 3. rm -rf `find %{buildroot}%{_datadir}/giac -empty` rm -rf `find %{buildroot}%{_datadir}/giac -name *~` rm -rf `find %{buildroot}%{_datadir}/doc/giac -empty` rm -rf `find %{buildroot}%{_datadir}/doc/giac -name *~` A 'find %{buildroot} -size 0 -delete' should be sufficient 4. Please, make %{_bindir}/* more explicit. 5. %doc doesn't list any License file. 6. %doc %{_datadir}/doc/giac %doc %{_datadir}/giac/doc %doc %{_datadir}/giac/examples If a documentation exists (English is better), you can package it in a '-doc' sub-package. http://fedoraproject.org/wiki/Packaging:Guidelines#Documentation 7. %package devel Summary: Development files for libgiac Requires: %{name} = %{version}-%{release} Use %{name}%{?_isa} = %{version}-%{release} because your package is architecture dependent. 8. You can perform a 'make check' in a %check section. Read INSTALL file in the source archive. 9. 'configure' considers an active --enable-lapack option by default. Lapack is not among BR packages. 10. Package build fails in rawhide with > cc1plus: some warnings being treated as errors Please, check it. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review