https://bugzilla.redhat.com/show_bug.cgi?id=1031342 Hans de Goede <hdegoede@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review? --- Comment #23 from Hans de Goede <hdegoede@xxxxxxxxxx> --- Hi Rob, Sorry for being very very slow with reviewing this. Here is a full review: Good: ===== - rpmlint checks return: xorg-x11-drv-freedreno.armv7hl: W: no-documentation 3 packages and 0 specfiles checked; 0 errors, 1 warnings. This can safely be ignored - package meets naming guidelines - package meets packaging guidelines - license (MIT) OK, matches source - spec file legible, in am. english - source matches upstream - package compiles on F-19 arm - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file Needs work: ========== -Drop the BuildRoot tag, it is not longer used -Switch Source0 to: http://ftp.x.org/pub/individual/driver/xf86-video-freedreno-1.0.0.tar.bz2 rather then using a git snapshot -Drop the autoreconf call, it is not needed when using a tarbal which has been properly made with "make dist" -Drop the "BuildRequires: autoconf automake libtool" they are only needed for autoreconf -Replace "make V=1" with "make %{?_smp_mflags} V=1" -Replace "make install DESTDIR=$RPM_BUILD_ROOT PREFIX=''" with "%make_install" this does the same, except that it drops the nonsense PREFIX='', which is not needed If you can re-sping the package fixing the needs work items, then I'll approve it and we can mvoe forward with including it in Fedora proper. Regards, Hans -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review