Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: aoetools - ATA over Ethernet Tools Alias: aoetools https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=235234 ------- Additional Comments From cweyl@xxxxxxxxxxxxxxx 2007-04-08 13:33 EST ------- There is a devnodes.txt that's included with the distribution that you may also want to stick in %doc + source files match upstream: 592f9f031796b4f0b90166a8cd5f9e30 aoetools-14.tar.gz 592f9f031796b4f0b90166a8cd5f9e30 ../aoetools-14.tar.gz package meets naming and versioning guidelines. + specfile is properly named, is cleanly written and uses macros consistently. + dist tag is present. + build root is correct. + license field matches the actual license. + license is open source-compatible. (GPL) License text included in package. + latest version is being packaged. + BuildRequires are proper. + compiler flags are appropriate. + %clean is present. + package installs properly + debuginfo package looks complete. + rpmlint is silent. + final provides and requires are sane: ** aoetools-14-1.fc6.x86_64.rpm == rpmlint == provides aoetools = 14-1.fc6 == requires /bin/bash /bin/sh libc.so.6()(64bit) libc.so.6(GLIBC_2.2.5)(64bit) libc.so.6(GLIBC_2.3)(64bit) libc.so.6(GLIBC_2.3.4)(64bit) libc.so.6(GLIBC_2.4)(64bit) ** aoetools-debuginfo-14-1.fc6.x86_64.rpm == rpmlint == provides aoetools-debuginfo = 14-1.fc6 == requires O %check is not present -- no tests defined, however + no shared libraries are added to the regular linker search paths. + owns the directories it creates. + doesn't own any directories it shouldn't. + no duplicates in %files. + file permissions are appropriate. + no scriptlets present. + code, not content. + documentation is small, so no -docs subpackage is necessary. + %docs are not necessary for the proper functioning of the package. + no headers. + no pkgconfig files. + no libtool .la droppings. + not a GUI app. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review