https://bugzilla.redhat.com/show_bug.cgi?id=1077762 Vít Ondruch <vondruch@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #6 from Vít Ondruch <vondruch@xxxxxxxxxx> --- * COPYING file have to stay in main package. - This is the main license file, therefore it has to stay in the main package [1]. * s/brypt/bcrypt/ - Please fix the typo in provides/obsoletes. * The obsoletes revision must be higher then the last release. - I.e. the correct Obsoletes should be: Obsoletes: rubygem-bcrypt-ruby <= 3.1.2-2 - Sorry, I could be more precise previously. * Upstream URL - The gem might contain this URL in metadata, but the rubyforge.org is going to be shut down. Please update the URL and ask upstream to do so. Otherwise, the package looks good => APPROVED. Please fix the remaining issues prior import into Fedora. [1] https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines#License_Text -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review