https://bugzilla.redhat.com/show_bug.cgi?id=1078588 --- Comment #2 from Michael Schwendt <bugs.michael@xxxxxxx> --- Consider pointing the fedora-review tool at this ticket, fedora-review -b 1078588 since it performs many helpful checks (it takes the package from the Spec/SRPM URLs). > License: GPLv2+ Can't confirm that. See: https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#.22or_later_version.22_licenses > BuildRoot: $RPM_BUILD_ROOT This is a no-op, because if you wanted to use the default $RPM_BUILD_ROOT, you would not need to set the BuildRoot tag. Also notice: https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag > BuildRequires: make gcc https://fedoraproject.org/wiki/Packaging:Guidelines#Exceptions_2 ( https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRequires_2 ) > %install > rm -rf ${RPM_BUILD_ROOT} Buildroot is emptied automatically nowadays. https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag > %{make_install} PREFIX=${RPM_BUILD_ROOT}/usr > install -m 755 -d ${RPM_BUILD_ROOT} That's a questionable order of those two commands. How could "make install" create anything in $RPM_BUILD_ROOT, if that one didn't exist yet? > %clean > rm -rf $RPM_BUILD_ROOT https://fedoraproject.org/wiki/Packaging:Guidelines#.25clean If you want to target EL5, either be explicit about that (and reuse the same spec for multiple dist targets) or consider forking the spec for EL. > %files > %defattr(-,root,root,-) %defattr is not needed anymore for any of the active Fedora releases and not even current EL5 either. https://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions > %doc %{_mandir}/man1/* Files below %_mandir are marked as %doc implicitly. See "rpm -E %__docdir_path". rpmlint tells: > Checking: ts-0.7.4-1.fc20.x86_64.rpm > ts-0.7.4-1.fc20.src.rpm > ts.x86_64: W: invalid-url URL: http://viric.name/soft/ts/ <urlopen error timed out> > ts.src: W: invalid-url URL: http://viric.name/soft/ts/ <urlopen error timed out> > ts.src: E: specfile-error warning: bogus date in %changelog: Wed Mar 18 2014 Jean-Marie Renouard <jmrenouard@xxxxxxxxx> - 0.7.4-1 > 2 packages and 0 specfiles checked; 1 errors, 2 warnings. Especially the %changelog errors ought to be corrected, since e.g. "date" tells that Mar 18 2014 is a Tuesday. > $ rpmls -p ts-0.7.4-1.fc20.x86_64.rpm > -rwxr-xr-x /usr/bin/ts > -rw-r--r-- /usr/share/man/man1/ts.1.gz License file is not included: https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text And no documentation files are included except for the manual page: https://fedoraproject.org/wiki/Packaging:Guidelines#Documentation > build.log https://fedoraproject.org/wiki/Packaging:Guidelines#Compiler_flags This has been a brief first look only. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review