[Bug 1079753] Review Request: perl-LWP-Protocol-connect - Provides HTTP/CONNECT proxy support for LWP::UserAgent

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1079753



--- Comment #1 from Petr Šabata <psabata@xxxxxxxxxx> ---
Since this isn't going to old EPELs (judging by the other reviews), you may
remove the line 35.

Line 40 is also generally unneeded.

Package the CHANGES and README files in %doc.

You don't need to BR perl(Test::Exception) as you don't run the author tests.

You should BR perl.

You may use the usually preferred DESTDIR in place of PERL_INSTALL_ROOT. 
EE::MM knows this.

"Provides" in your description should begin with a lowercase "p".

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]