Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: apr-util https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225254 ------- Additional Comments From jeremy@xxxxxxxxxxxxxxx 2007-04-08 01:55 EST ------- (In reply to comment #4) Thanks for the changes. Everything is good except for (7) > > E: apr-util use-of-RPM_SOURCE_DIR > > This is not prohibited by packaging guidelines, see f-m@ flamewar. Understood, since the spec does not write to RPM_SOURCE_DIR then it is ok. > > 7. .la files exist and must be removed > > The .la file is part of the defined build interface for this package. According to http://fedoraproject.org/wiki/Packaging/ReviewGuidelines - MUST: Packages must NOT contain any .la libtool archives, these should be removed in the spec. Accordingly I cannot give final approval until this is addressed. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review