https://bugzilla.redhat.com/show_bug.cgi?id=1079749 --- Comment #3 from Petr Šabata <psabata@xxxxxxxxxx> --- I see you've removed some of the old cruft Ralf pointed out but not all of it. Since the answer to "Do you intend to support rhel < 6?" is obviously "no", drop the line 33, too. There are still one more missing build-time dependencies you should add: perl, used in the spec perl(File::Spec::Functions), used in various tests For the optional tests, you may also buildrequire: perl(Test::Pod) >= 1.14 perl(Test::Pod::Coverage) >= 1.04 Consider using the description from the POD instead of just paraphrasing the Summary. Package the README and Changes files as documentation, e.g. by adding the following to your %files section: %doc Changes README More tips: Line 39 is not needed and may be safely dropped. Sort your deps alphabetically; it's easier to maintain later. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review