https://bugzilla.redhat.com/show_bug.cgi?id=226527 Kalev Lember <kalevlember@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kalevlember@xxxxxxxxx --- Comment #3 from Kalev Lember <kalevlember@xxxxxxxxx> --- > -make install DESTDIR=$RPM_BUILD_ROOT > +make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p" I'm not much fan of adding overrides like that. Could you perhaps switch to using plain %make_install instead? There's an rpm ticket open to add the "install -p" override to the %make_install macro, so that all users of the macro would get this automatically. I would prefer to leave "install -p" out from here and rely on %make_install doing the right thing. https://bugzilla.redhat.com/show_bug.cgi?id=959872 > +desktop-file-validate $RPM_BUILD_ROOT%{_sysconfdir}/xdg/autostart/vino-autostart.desktop || : There's no value in validating the desktop file if you discard the exit code with "|| :". The reason why the packaging guidelines mandate that all desktop files are validated is to ensure that broken desktop files don't get in the distribution. Other changes look good to me. And thanks for reviewing these packages! -- You are receiving this mail because: You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review