https://bugzilla.redhat.com/show_bug.cgi?id=1036320 Christopher Meng <cickumqt@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #22 from Christopher Meng <cickumqt@xxxxxxxxx> --- (In reply to Kevin Fenzi from comment #21) > Thanks for the review! > > 1. See earlier discussion about the /etc/nftables/ scripts. I think in this > case it's valid to have them executable and still marked as config. Ok. > 2. That isn't something this configure script understands: > configure: WARNING: unrecognized options: --disable-silent-rules > I could patch the doc building to be more verbose, but how important is it? > It shouldn't be needed to see compiler flags or anything... Ok. > 3. It doesn't currently. It's just the command line utils. Perhaps someday > it would grow some functionality around that, but it might never do so and > just depend on things that use it at a higher level like firewalld to save > persistent rules. Ok. --------------------------------- nftables.i686: W: spurious-executable-perm /usr/share/man/man8/nftables.8.gz Can you please ensure that it's 644 set? Please do this before SCM import. PACKAGE APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review