https://bugzilla.redhat.com/show_bug.cgi?id=1070702 --- Comment #2 from Ralf Corsepius <rc040203@xxxxxxxxxx> --- Some remarks on this package: - Building doesn't honor RPM_OPT_FLAGS. One work-around to this seems to be passing them to make through XCFLAGS, i.e. to use make %{?_smp_mflags} XCFLAGS="${RPM_OPT_FLAGS}" - The package contains testsuite, which should be excercised, IMO. AFAIS, it can be invoked this way: %check rm -rf testdb make test LD_LIBRARY_PATH=$(pwd) - COPYRIGHT and LICENSE need to be added to %doc - Shipping Doxyfile in %doc doesn't make sense. It should be removed from %doc. - The package seems to support doxygen-generated docs. I'd recommend to build and package them (but I haven checked whether these actually are useable). Finally, the naming of the package is not clear to me. I see a mix of lmdb, mdb and liblmdb, which seems inconsistent to me. Unfortunately I don't have a clear vision/imagination about what would be the appropriate name for this package, rsp. under which name its users would expect to find it. Also, noticing openldap seems to be the origin, I am not sure if prefixing this package with "openldap" would be adequate (i.e. openldap-lmdb or openldap-liblmdb). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review