https://bugzilla.redhat.com/show_bug.cgi?id=988866 Remi Collet <fedora@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs? --- Comment #16 from Remi Collet <fedora@xxxxxxxxxxxxxxxxx> --- (In reply to Adam Williamson from comment #15) > Is it really correct to ship the tests as docs? Maybe a separate subpackage > would be better? Just a thought, not blocking review. I mostly consider "tests" as "examples" of using the library, so I think providing them as %doc makes sense. I only provides tests for 2 reasons - examples - be consistent with "pecl list-files foo" For some extensions, when a -devel subpackage exists (for headers) I also put examples and tests in this subpackage. Or when test suite is very large. Thanks for the review. -- You are receiving this mail because: You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review