https://bugzilla.redhat.com/show_bug.cgi?id=1063040 Ken Dreyer <ktdreyer@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review? --- Comment #12 from Ken Dreyer <ktdreyer@xxxxxxxxxxxx> --- Hi Nitesh, a couple of additional comments: - The MIT-LICENSE file in rubygem-em-socksify-0.3.0-5.fc20.src.rpm says "Copyright (c) 2009 - 2014, David Waite and Other Contributors". This is not correct. The main contributor is Ilya Grigorik, and the first commit in Git is from 2011 (not 2009). We need to be very careful that we do not accidentally indicate that copyright belongs to the wrong person. (Please see the next item below for a corrected copyright statement in the MIT-LICENSE file.) - When you see that the MIT license file is missing from upstream, the first place to attempt to solve that is upstream, rather than downstream in Fedora. I've submitted this change here: https://github.com/igrigorik/em-socksify/pull/15 In the future, if you are packaging software that does not have the full license text, please submit this sort of change upstream first. - For Ruby Gem packages, it's also useful for upstream to have the MIT license metadata in the gemspec. Here's the proposal for that: https://github.com/igrigorik/em-socksify/pull/14 . Again, in the future, please do submit this sort of thing upstream for your packages. - Please update the URL to use "https" instead of "http". I've proposed this upstream here: https://github.com/igrigorik/em-socksify/pull/16 - Please remove the "Generated from ... gem2rpm" comment at the top of the file. This line is not necessary for the package and it will become stale over time. - Please remove the trailing spaces at the end of the rubygems-devel line (line 17) and popd line (line 56): 17 BuildRequires: rubygems-devel 56 #popd - Please remove the following line: BuildRequires: ruby This is only necessary on the arch-specific (binary) gems. Since your em-socksify package is noarch, you only need ruby(release). - Please adjust the following line: %{gem_instdir}/spec/* to be simply %{gem_instdir}/spec This will tell RPM to capture the spec directory as well as the contents within. Please remove the trailing whitespace from this line as well. - Please add a second percent sign (%) to the macros that are commented in %check. So "%check" becomes "%%check", and "./%{gem_instdir}" becomes "./%%{gem_instdir}". The reason for doing this is that rpmlint will complain about unescaped macros in the comments. Even if a macro is commented, RPM will still expand it. Sometimes its innocuous and it's not a problem, but other times it can cause unexpected behavior, so it's always best to escape all the rpmlint warnings about this to be on the safe side. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review