Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: php-pear-HTML-QuickForm-ElementGrid - Meta-element which holds any other element in a grid Alias: pear-ElementGrid https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222575 bugzilla@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |medium ------- Additional Comments From sebastien.prudhomme@xxxxxxxxx 2007-04-07 09:58 EST ------- + rpmlint output (none) + right package name (follows PEAR package naming scheme) + build for noarch + spec file name = %{name}.spec + package version = tarball version + uses 1%{?dist} release + web site url checked: http://pear.php.net/package/HTML_QuickForm_ElementGrid + source file url checked + LGPG license ? missing license file + requires: php-pear(PEAR) - requires: php >= 4.3.0 (not sure for this as php-pear requires php yet but Wiki page says a PEAR package MUST requires it) + requires: php-pear(HTML_QuickForm) >= 3.2.5 (as written in PEAR XML package description) + requires: php-pear(HTML_Table) >= 1.7.5 (as written in PEAR XML package description) + provides: php-pear(HTML_QuickForm_ElementGrid) = %{version} + uses '%setup -q -c' as suggested in PEAR additional hints + uses PEAR macros + uses recommended scriptlets for registering and unregistering the module + written in english (not my native language so i hope all is OK) + md5 of source file same as the one of the source file on the official web site + build and installed without problem on fc6 + sample elementGrid.php tested successfully + no duplicate files + uses %defattr(-,root,root,-) + doesn't own %{pear_phpdir}/HTML/QuickForm directory ? group should be Development/Libraries not Development/Languages + buildroot %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review