[Bug 1079745] Review Request: perl-Excel-Template - Create Excel files from templates

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1079745

Ralf Corsepius <rc040203@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rc040203@xxxxxxxxxx



--- Comment #1 from Ralf Corsepius <rc040203@xxxxxxxxxx> ---
* These Requires: should be removed from the *.spec:
Requires:       perl(XML::Parser)
Requires:       perl(IO::Scalar)
Requires:       perl(File::Basename)
Requires:       perl(Spreadsheet::WriteExcel::Utility)
Rpm automatically detects them, causing the manually specified ones to appear
twice on the resulting binary rpms.


* BuildRequires:  perl(Spreadsheet::WriteExcel)
should match the run-time requirement:
Requires:       perl(Spreadsheet::WriteExcel) >= 0.42

i.e. change
 BuildRequires:  perl(Spreadsheet::WriteExcel)
into
 BuildRequires:  perl(Spreadsheet::WriteExcel) >= 0.42


* I'd recommend to "chmod"s the source-files in %build ("Fix the sources") 
instead to "chmod" them after installation in %install ("Workaround the bug").


* The package ships a LICENCE file
=> MUST add LICENCE to %doc

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]