Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: gdb https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225783 rc040203@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rc040203@xxxxxxxxxx ------- Additional Comments From rc040203@xxxxxxxxxx 2007-04-07 00:00 EST ------- This package will need a lot of love ;) Some obious issues: 1. When running configure ... checking for libexpat... no configure: WARNING: expat is missing or unusable; some features may be disabled. => Missing BR: libexpat-devel 2. %makeinstall %makeinstall should not be used if a package supports make DESTDIR=.. install Old gdb didn't, but modern ones do (AFAICT, gdb-6.6 does). 3. The way, the infos are being installed. I don't see much wrong with the way you are doing it, but ... I'd recommend to convert this to the way most packages handle it nowadays. 4. Prereq: info This construct is being frowned upon. It should be replaced with Requires(pre): /sbin/install-info Requires(post): /sbin/install-info 5. running the tests should be put into a separate %check section. 6. The rationale for the "version-reporting paragraph" escapes me. I recommend to remove it. 7. Package doesn't honor RPM_OPT_FLAGS: gdb-6.3-warnings-20050317.patch:+-Wp,-U_FORTIFY_SOURCE" When running the testsuite: ... Running ../../../gdb/testsuite/gdb.base/auxv.exp ... WARNING: can't generate a core file - core tests suppressed - check ulimit -c => You probably should set ulimit -c unlimited before running the tests ... Running ../../../gdb/testsuite/gdb.base/prelink.exp ... sh: prelink: command not found I was running rpmbuild as ordinary user, who didn't have /usr/sbin in $PATH Finally: Running the testsuite hangs when building this package on FC6. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review