[Bug 1079749] Review Request: perl-Test-Image-GD - A module for testing images using GD

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1079749

Ralf Corsepius <rc040203@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rc040203@xxxxxxxxxx



--- Comment #1 from Ralf Corsepius <rc040203@xxxxxxxxxx> ---
* These Requires: should be removed from the spec.
Requires:       perl(GD)
Requires:       perl(Scalar::Util)
Requires:       perl(Test::Builder)
Rpm's perl-deptracker generates these (and others) automatically.

* Some BR:s are missing. Please add:
BuildRequires:  perl(Exporter)
BuildRequires:  perl(Test::Builder::Tester)
BuildRequires:  perl(strict)
BuildRequires:  perl(warnings)

* Do you intend to support rhel < 6?
If no, you can get rid of many rpm-anacronisms inside of your spec, such as
%clean, rm -rf $RPM_BUILD_ROOT, BuildRoot:..., %defattr etc.

NB: cpanspec is a tool aiming at assisting packagers. The spec files it
generates are far from being "perfect" and usually require to be manually
modified.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]