Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ocsinventory-ipdiscover - Open Computer and Software Inventory Next Generation client https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=235376 wolfy@xxxxxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |wolfy@xxxxxxxxxxxxxxxxxx Flag| |fedora-review? ------- Additional Comments From wolfy@xxxxxxxxxxxxxxxxxx 2007-04-06 19:05 EST ------- GOOD - rpmlint checks do not return anything - package meets naming guidelines - package meets packaging guidelines - license (GPL ) OK, matches source; upstream did not include the full license, but the only existing doc (a README) mentions that the license is GPL and points to the URL - spec file legible, in am. english - source matches upstream, sha1sum 06acb6c071040d2ae6d3c26109e526afba660835 OCSNG_LINUX_AGENT_1.01.tar.gz - package compiles on devel (x86_64) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all files and directories that it creates; does not take ownership of foreign files and directories - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - not a GUI, so no need for .desktop file - no static content. no libtool / pkgconfig files SHOULD - compiles and builds in mock/devel/x86_64 - there are no translations available, but %description is also in French - no scriptlets - the program does start and seems to run without problems. I cannot do full tests because I do not have the other needed programs (the agents). If someone else could test this, please give us a hand. Unless someone steps in pointing to problems that I have not spotted, Wednesday I will approve this package (I think it's a good idea to wait till after Easter). Meanwhile, Remi, please think of a method to preserve the timestamp of the README file. Using perl to remove the CR/LF line endings affects it. Maybe using "touch -r" before and after modifying the file ? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review