https://bugzilla.redhat.com/show_bug.cgi?id=1076863 --- Comment #17 from Luis Pabon <lpabon@xxxxxxxxxx> --- Hi Michael, thank you for taking a look at the spec file again. > What is the purpose of this section? > > | %if ( 0%{_for_fedora_koji_builds} ) > | Source0: > https://github.com/lpabon/%{name}/archive/v%{version}/%{name}-%{version}.tar. > gz > | %else > | Source0: %{name}-%{version}.tar.gz > | %endif > > Those two Source0 tags are equivalent (because the tarball name is the > same), except that the former is preferred because it also contains the full > download location. -- Fixed > > > > %check > > make check > > > > %install > > The %check section is executed _after_ %install, so it ought to be placed > after %install in the spec file. Btw, there are scenarios where a custom > %check section needs to operate on buildroot contents, and the buildroot is > empty before %install. -- Fixed > > > > [x]: %build honors applicable compiler flags or justifies otherwise. > > Not true. > https://fedoraproject.org/wiki/Packaging:Guidelines#Compiler_flags -- Fixed -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review