https://bugzilla.redhat.com/show_bug.cgi?id=1078074 Ralf Corsepius <rc040203@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs? --- Comment #3 from Ralf Corsepius <rc040203@xxxxxxxxxx> --- Thanks for the review, Xavier! (In reply to Xavier Bachelot from comment #2) > The package looks good, only SHOULD stuff to take a look at. Fix before > import if you wish : > - You should set AUTOMATED_TESTING=1 in the test section and add a couple > BR:s for better test coverage (Test::CPAN::Meta, Perl::MinimumVersion, > Test::MinimumVersion, Test::Pod). These days, most perl-module maintainers don't care about AUTOMATED_TESTING tests anymore (many maintainers seem to be trying hard to prevent us from running them), which has led me not to look into them anymore. I'll likely have a brief look into it after git import, but definitely won't invest much effort. > - You should ask upstream to add a license file. Nothing on this planet requires upstreams to do so. I have no idea why people are enforcing this - Likely it's rpmlint's brokenness ;) New Package SCM Request ======================= Package Name: perl-Set-Tiny Short Description: Simple sets of strings Owners: corsepiu Branches: f19 f20 InitialCC: perl-sig -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review