https://bugzilla.redhat.com/show_bug.cgi?id=1074515 --- Comment #13 from Jan Kaluža <jkaluza@xxxxxxxxxx> --- (In reply to Vít Ondruch from comment #12) > * Upstream patches > - I am wondering, why the Patch2 is not upstreamed? Or is there some > upstream ticket for this? I've checked all patches and it looks they are not needed with newer versions of Passenger. I will remove them. > > * Remove F18 support > - What is the purpose of F18 support? Shouldn't it be just dropped? It was there to stay consistent with upstream spec file, but you are right it's not needed for the official Fedora and won't be probably needed for upstream soon too. > * Is passenger supported on RHEL5? > - I am wondering, since there are several conditionals, which could be > removed. Moreover, I can't see any build in Koji. And I doubt that > passenger > supports Ruby 1.8.5. It's not. I will remove these conditionals. > * %{passenger_libdir} into %{_datadir} > - Isn't the content of %{passenger_libdir} just noarch stuff? There are some internally used binaries, so it is not noarch. I used %{_datadir} originally, but I had to change that to libdir because of that. > * Is there reason to keep ruby_extension_source in -devel? > - Aren't the sources kept in -debuginfo? Passenger is able to compile various nginx versions for Passenger standalone mode. For this functionality, it needs it's source code. I'm not sure about this particular source file. I will ask upstream if it's really needed. > * Duplicated passenger_native_support.so > - This library is included in main package as well as in -native-libs > subpackage. This is probably overlook. > - I am wondering what is the purpose of -native-libs anyway. Although the > description says "It has been separated so that installing a new Ruby > interpreter only necessitates rebuilding this package.", I somehow mis > how > it would be achieved in reality? Good point. I think it will make sense to not provide this as separate subpackage. I will consult with upstream. > * Object files in passenger/common > - What is the intention here? Why they are kept in devel package? As I stated above, they are there to allow passenger to compile nginx (if admin asks Passenger to do it). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review