Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: zlib https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226671 ------- Additional Comments From pertusus@xxxxxxx 2007-04-06 07:47 EST ------- Created an attachment (id=151869) --> (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=151869&action=view) spec file that incorporates all my comments I removed the autotools patch in this spec. I think that such change is for upstream, not in a fedora package. Moreover this is not similar with upstream since the tests are removed. I cleaned the build such that the package is built in the build section and also used more rpm macros. and I added the manual, in my opinion this is a must - don't use the autotools, instead revert to the previous build procedure - ship the manual to have a description of the API - build the libraries in the %%build section rpmlint output is explained in comments in the spec E: zlib configure-without-libdir-spec W: zlib make-check-outside-check-section make check E: zlib configure-without-libdir-spec W: zlib make-check-outside-check-section make check Feel free to modify it again (for example if you like the build but not the manual). -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review