Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: glchess - GlChess, a 3d Chess game using OpenGL https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=234436 ------- Additional Comments From j.w.r.degoede@xxxxxx 2007-04-06 03:11 EST ------- (In reply to comment #2) > Created an attachment (id=151678) --> (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=151678&action=view) [edit] > mock build log of glchess-1.0.4-1 on FC-devel i386 > > Well, for 1.0.4-1: > > * BuildRequires > - mockbuild failed. At least desktop-file-utils is missing > for BuildRequires. > Fixed > * Executable permissions/shebang > -------------------------------------------- > # make rpmlint happy > chmod +x $RPM_BUILD_ROOT%{python_sitelib}/%{name}/scene/opengl/png.py \ > $RPM_BUILD_ROOT%{python_sitelib}/%{name}/gtkui/__init__.py > -------------------------------------------- > - IMO the resolution should be opposite. > Fixed for one of the 2 files, the other can be executed stand alone > * GConf files > -------------------------------------------- > %config(noreplace) %{_sysconfdir}/gconf/schemas/glchess.schemas > -------------------------------------------- > - Well, while I cannot find any wiki packages, however I am > sure that GConf schemas files under /etc/gconf/schemas is > generally _not_ regarded as config file and should not > marked as %config (even if rpmlint complains about it). > Fixed > * Some python related dependency > - Well, would you check the following import sentence? > * import Image (from opengl/texture.py: Perhaps python-imaging > It seems that "Packages" link from http://glchess.sourceforge.net/ > requires it) python-imaging is not required, it will fallback to an alternative png loading routine if python-imageging is not installed, and all the included textures are png, so that will work fine: try: self.__loadPIL(fileName) except ImportError: self.__loadPNG(fileName) New version here: Spec URL: http://people.atrpms.net/~hdegoede/glchess.spec SRPM URL: http://people.atrpms.net/~hdegoede/glchess-1.0.4-2.fc7.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review