https://bugzilla.redhat.com/show_bug.cgi?id=1066672 --- Comment #8 from Steven Dake <sdake@xxxxxxxxxx> --- (In reply to James Slagle from comment #7) > Spec URL: > https://raw.github.com/agroup/tripleo-rpm-spec-files/master/tripleo-image- > elements/openstack-tripleo-image-elements.spec > SRPM URL: > http://repos.fedorapeople.org/repos/openstack-m/openstack-m/fedora-20/SRPMS/ > openstack-tripleo-image-elements-0.6.0-3.fc20.src.rpm > > > (In reply to Steven Dake from comment #5) > > ===== EXTRA items ===== > > > > Generic: > > [x]: Rpmlint is run on all installed packages. > > Note: There are rpmlint messages (see attachment). > > [x]: Spec file according to URL is the same as in SRPM. > > Rpmlint > > ------- > > Checking: openstack-tripleo-image-elements-0.6.0-2.fc20.noarch.rpm > > openstack-tripleo-image-elements-0.6.0-2.fc20.src.rpm > > openstack-tripleo-image-elements.noarch: E: non-executable-script > > /usr/share/tripleo-image-elements/tempest/tests2skip.py 0644L /usr/bin/python > > openstack-tripleo-image-elements.noarch: E: non-executable-script > > /usr/share/tripleo-image-elements/snmpd/files/check_proc_open_files.py 0644L > > /usr/bin/env > > openstack-tripleo-image-elements.noarch: W: hidden-file-or-dir > > /usr/share/tripleo-image-elements/os-apply-config/os-config-applier/.os- > > config-applier > > > > Is there some reason there is a hidden file in this directory? This seems > > suspect to me. > > The reason is you can't have empty directories in git, and the > os-apply-config element expects this directory to exist when the element is > installed in an image. So, that's why the hidden file was added. > Couldn't you just use the %dir directive to create the directory in /usr/share/tripleo-image-elments/os-apply-config/os-config-applier? I am missing how git is involved in the hidden file, other then the need to have the empty directory. My recommendation would be as follows: 1) if the empty file is in the upstream git repo to allow the directory to be present in git, the upstream would be better served by an empty README, rather then a hidden file which may cause confusion. Hidden files indicate configuration options typically, rather then placeholders to workaround git issues. If this is the case, I'd suggest filing a bug with upstream to indicate files prepended with period are used for configuration, and to rename the file to something that folks can see (such as README). I won't block the review for this condition but do have an expectation that an upstream bug be filed. 2) If the empty file is added by the packager as part of the git export process, a %dir should fix the problem. Could you get back to me on this point? > > openstack-tripleo-image-elements.noarch: E: non-executable-script > > > > this wont work with DIB - it requires files to be +x > > > > /usr/share/tripleo-image-elements/iptables/bin/add-rule 0644L /bin/bash > > add-rule is only run on built images at instance run time. When it's > installed onto the image, it is 755. But, there's no need for it to be +x > here. I could submit a patch upstream, but the only point of that would be > to make rpmlint happy :). > ok then rpmlint warning can be ignored > > openstack-tripleo-image-elements.noarch: E: non-executable-script > > > > > > this wont work with DIB - it requires files to be +x > > /usr/share/tripleo-image-elements/openstack-ssl/os-refresh-config/pre- > > configure.d/70-stunnel-permissions 0644L /bin/bash > > > > this wont work with DIB - it requires files to be +x > > This one has been fixed upstream, and I added the new patch to the rpm build. > nice > > > > openstack-tripleo-image-elements.noarch: W: hidden-file-or-dir > > /usr/share/tripleo-image-elements/horizon/os-apply-config/etc/horizon/. > > secret_key_store > > > > Does this file really need to be hidden? > > You can configure horizon to use any file for the secret key, but the > upstream convention (and how the element works) is to use the hidden file. > See: > http://git.openstack.org/cgit/openstack/horizon/tree/openstack_dashboard/ > settings.py#n239 > if that is the upstream convention then that wfm. > > > > openstack-tripleo-image-elements.src:3: W: mixed-use-of-spaces-and-tabs > > (spaces: line 3, tab: line 1) > > > > please fix the tab/spacing usage and stick to one. > > Fixed. nice -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review