https://bugzilla.redhat.com/show_bug.cgi?id=1077746 Rex Dieter <rdieter@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #1 from Rex Dieter <rdieter@xxxxxxxxxxxx> --- naming: ok sources: ok c8f2bb33d2615be39eed28969173a12e appstream-glib-0.1.0.tar.xz licensing: ok builds/installs: ok scriptlets: ok looks good in general, some mostly smaller items: 1. SHOULD use arch'd dependency in -devel subpkg, use Requires: %{name}%{?_isa} = %{version}-%{release} instead of Requires: %{name} = %{version}-%{release} 2. SHOULD omit deprecated tags %defattr 3. SHOULD up build dep BuildRequires: glib2-devel >= 2.16.1 to BuildRequires: glib2-devel >= 2.39 build fails on f20 using glib2-2.28, with: ./.libs/libappstream-glib.so: error: undefined reference to 'g_str_tokenize_and_fold' which I believe is new in 2.39 (I could be wrong though) 4. SHOULD track library soname in %files, I'd prefer: %{_libdir}/libappstream-glib.so.1* instead of: %{_libdir}/*libappstream-glib*.so.* which avoids the possibility of surprise soname bumps. 5. SHOULD omit unused macro: %define alphatag .20140318git As these are not blockers, APPROVED (though I'd prefer you consider addressing these prior to doing any official builds in koji). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review