[Bug 1024589] Review Request: zlib-js - JavaScript library reimplementing compression

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1024589

Jamie Nguyen <jamielinux@xxxxxxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |1077322



--- Comment #7 from Jamie Nguyen <jamielinux@xxxxxxxxxxxxxxxxx> ---
To paraphrase a discussion with T.C. via email:
What I thought was a working solution turns out to be not really working at
all. %{_arch} is the build host architecture not the target architecture, so if
an EPEL package is sent to a x86_64 builder then the nodejs-zlibjs subpackage
will be unconditionally present even in PPC repositories. And conversely, if
the package is sent to a PPC builder then the nodejs-zlibjs subpackage will be
unconditionally absent even in x86_64 repositories. The only solution with our
current buildsystem appears to be to make the package arched (remove BuildArch:
noarch, and use %ifarch for the subpackage).

I suggested instead that we split them into two completely separate packages
and symlink js-zlib/node-zlib.js to the nodejs-zlibjs package. This would
allow:
 - js-zlib to remain completely free of architecture restrictions
 - nodejs-zlibjs to be restricted to %{nodejs_arches}
 - both packages to remain noarch

I have confirmed by running the test suite that the new nodejs-zlibjs package
works as intended with the symlink.

Review Request: nodejs-zlibjs
https://bugzilla.redhat.com/show_bug.cgi?id=1077322

Spec URL: http://jamielinux.fedorapeople.org/gruntjs/js-zlib.spec
SRPM URL:
http://jamielinux.fedorapeople.org/gruntjs/SRPMS/js-zlib-0.2.0-4.fc21.src.rpm

* Mon Mar 17 2014 Jamie Nguyen <jamielinux@xxxxxxxxxxxxxxxxx> - 0.2.0-4
- As it turns out, matching {_arch} won't solve our problem as it indicates
  the architecture of the build host not the target architecture. Instead
  split nodejs-zlibjs into a separate package, as otherwise js-zlib would be
  restricted to {nodejs_arches}. bin/node-zlib.js will remain in the js-zlib
  package, while nodejs-zlibjs will depend on js-zlib and have a symlink.
- add logic for building on EPEL 6


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1077322
[Bug 1077322] Review Request: nodejs-zlibjs - JavaScript library
reimplementing compression, made available for Node.js
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]