https://bugzilla.redhat.com/show_bug.cgi?id=1069257 --- Comment #18 from Till Hofmann <hofmann@xxxxxxxxxxxxxxxxxxx> --- (In reply to Michael Schwendt from comment #17) > They have chosen to patch it as well, but differently. They add an Autotools > based configure script and include a pkgconfig file in their -dev package. Do you think we should adopt their patches or can we stay with cmake? > Depending on which other projects rely on building with the pkgconfig file > (or, in the future, your CMake files), it may become necessary to join > forces and agree on a compatible build framework (even if upstream does not > want to include those files [yet], maybe not even in a contrib folder). > > $ rpm -qp --provides fparser-4.5.1-3.fc20.x86_64.rpm |grep ^l > libfparser.so.4.5()(64bit) > > Your libfparser.so.4.5 SONAME currently differs from Debian's library naming > scheme. That's a binary incompatibility to think about as well. > > Inventing library sonames at the distribution level (without support from > upstream) is non-trivial almost always. Skimming over the fparser > changelog/news it's hard for me to predict how compatible the individual > minor releases have been and will be. Especially the burden of checking > releases for ABI compatibility (and updating the SONAME version > appropriately) will be on your shoulders (i.e. the packager's shoulders). > Debian's libfoo-$major.$minor.so naming is a slightly better compromise, > because it is explicit about $major.$minor being the product release version > and not being a varying library interface version. > > Thoughts? Seems reasonable. From the changelog it seems like any patch version update is compatible to the previous version while all minor version updates may change the ABI, but I guess we shouldn't rely on that. I've adopted the changes you suggested. SPEC file: http://thofmann.fedorapeople.org/fparser.spec cmake patch: http://thofmann.fedorapeople.org/fparser.cmake.patch SRPM: http://thofmann.fedorapeople.org/fparser-4.5.1-4.fc20.src.rpm I don't know much about cmake so I'm not sure if the way I added the symlink libfparser.so -> libfparser-4.5.so is the proper way to do so. > > %{_libdir}/cmake/* > > When not adding "Requires: cmake" the directory needs to be included in the > package Fixed -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review