https://bugzilla.redhat.com/show_bug.cgi?id=1077081 Lubomir Rintel <lkundrak@xxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |182235 (FE-Legal) --- Comment #7 from Lubomir Rintel <lkundrak@xxxxx> --- 0.) Please package a more recent version. 4.3.0 seems already available. 1.) Source can not be downloaded > spread.src: W: file-size-mismatch spread-src-4.2.0.tar.gz = 736189, > http://www.spread.org/download/spread-src-4.2.0.tar.gz = 2628 > 1 packages and 0 specfiles checked; 0 errors, 3 warnings. Please don't use the URL in Source tag then, but in a comment instead: # Download it from: http://www.spread.org/download/spread-src-4.2.0.tar.gz Source0: %{name}-src-%{version}.tar.gz 2.) Why do you ship static package? Static linking is strongly discouraged and should be avoided whenever possible. 3.) Why do you override docdir with pkgdocdir? Apart from that it won't build with older RPM (such as in el7 and older), it's not a very usual thing to do and result in path names that are not stable across package releases. 4.) Libraries are shipped in -devel packages You probably want to include in the main or -libs package. That will need moving the ldconfig scriptlets as well. (In reply to Jan Holcapek from comment #5) > Regargind the invalid-license warning: I've dropped a question to > legal@xxxxxxxxxxxxxxxxxxxxxxx asking whether Spread Open Source License is > suitable for a Fedora package. Thanks. I believe they are merely clarifying the legal matters without changing the meaning and their advertising clause is very 4-clause BSDish, therefore it should be fine for Fedora as long as nothing GPLed links to it. Adding FE_LEGAL dependency. Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=182235 [Bug 182235] Fedora Legal Tracker -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review