https://bugzilla.redhat.com/show_bug.cgi?id=845115 Bohuslav "Slavek" Kabrda <bkabrda@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Whiteboard|Stalled Reviewer | --- Comment #18 from Bohuslav "Slavek" Kabrda <bkabrda@xxxxxxxxxx> --- Sorry for the long response time. My notes: - When renaming a package, you should not only Obsolete it, but also Provide it [1]. - rpmlint reports mixed use of tabs and spaces in specfile. Please decide for one and use it throughout the whole specfile. - The README file says "client.py taken from recaptcha-client licenced MIT/X11 by Mike Crawford." - I therefore suggest changing License tag to "BSD and MIT". - The tests are not actually run. Mock outputs this: DEBUG: + /usr/bin/python2 -m unittest DEBUG: ---------------------------------------------------------------------- DEBUG: Ran 0 tests in 0.000s Please look into this. [1] http://fedoraproject.org/wiki/Packaging:Guidelines#Renaming.2FReplacing_Existing_Packages -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review