https://bugzilla.redhat.com/show_bug.cgi?id=1024589 --- Comment #5 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- Tom, sorry for the slow response. I think that the naming proposed by Jamie is OK: nodejs-zlibjs and js-zlib. The tarball is called zlibjs, so even upstream seems to skip the dot. Jamie, thank you for the updated spec file. It seems much better than my version. I made two changes though: - I reverted your replacement of sed with patch, since the patch seems very fragile and will probably have to be updated quite often when upstream changes the ant file - I simplified the arch condition using grep May I add you as a co-maintainer? Spec URL: http://in.waw.pl/~zbyszek/fedora/zlib-js.spec SRPM URL: http://in.waw.pl/~zbyszek/fedora/zlib-js-0.2.0-3.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review