https://bugzilla.redhat.com/show_bug.cgi?id=1076863 Niels de Vos <ndevos@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lpabon@xxxxxxxxxx Flags| |needinfo?(lpabon@xxxxxxxxxx | |) --- Comment #1 from Niels de Vos <ndevos@xxxxxxxxxx> --- After improving your package with the hints and suggestions given below, please run your new packages and spec file through rpmlint to verify the changes. Include the output from rpmlint in your comment when you inform me of an updated src.rpm and spec file. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Needs clarification -> = suggested action to take Q: = question you need to answer Issues: ======= - Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files directly in %_libdir. See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages -> Put the libcmockery2.so file in the -devel subpackage. - All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. Note: These BR are not needed: gcc make See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2 -> gcc and make are always installed in the buildroot, please remove them from the BuildRequires. - ldconfig called in %post and %postun if required. Note: /sbin/ldconfig not called in cmockery2 See: http://fedoraproject.org/wiki/Packaging/Guidelines#Shared_Libraries -> Your package caries lib*.so* files, you need to execute ldconfig in %post and %postun. - Package does not contain any libtool archives (.la) Note: cmockery2-devel : /usr/lib/libcmockery.la See: http://fedoraproject.org/wiki/Packaging/Guidelines#StaticLibraries -> Please prevent building the .la file, or delete the file after compilation. If this really is needed (I don't think it is) for static compilation, include it in the -static package. - The Source0 url is invalid. -> use https://github.com/lpabon/%{name}/archive/v%{version}/%{name}-%{version}.tar.gz - The summary text for the package description should no end in a '.'. -> Remove the . at the end of the Summary lines. - There is no version on the last entry in the %changelog. -> Please add a <version>-<revision> in the changelog. - The %clean section is only needed for EPEL-5 packages. Q: Are you planning to provide this package in EPEL-5? - Invalid BuildRoot is used. See: https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#BuildRoot_tag -> If you want to provide the package in EPEL-5, set the BuildRoot to one of the variants from https://fedoraproject.org/wiki/EPEL:Packaging#BuildRoot_tag - Subpackages -devel and -static are missing a versioned dependency on the main package. -> Add "Requires: %{name}%{?_isa} = %{version}-%{release}" in cmockery2-devel and cmockery2-static. - The package contains obsolete autotools m4 macros. See: https://fedorahosted.org/FedoraReview/wiki/AutoTools Q: Can be dropped, or are they required for EPEL-5? - -devel contains unneeded files. -> NEWS is empty, and INSTALL does not contain any useful information. These files should not get installed. Accepted warnings: ================== - Spelling errors for 'Cmockery' and 'executables'. - exit() call in libcmockery.so in cmockery.c:exit_test(). ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: There is no build directory. Running licensecheck on vanilla upstream sources. Licenses found: "Apache (v2.0)", "Unknown or generated". 5 files have unknown license. Detailed output of licensecheck in /srv/devel/fedora- pkgs/cmockery2.bz1076863/1076863-cmockery2/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [!]: Changelog in prescribed format. [?]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf %{buildroot} present but not required [x]: Sources contain only permissible code or content. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 122880 bytes in 18 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: Static libraries in -static or -devel subpackage, providing -devel if present. Note: Package has .a files: cmockery2-static. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Buildroot is not present Note: Invalid buildroot found: %{_tmppath}/%{name}-root See: http://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag [?]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: %clean present but not required [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [!]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in cmockery2-devel , cmockery2-static [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [!]: SourceX tarball generation or download is documented. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Reviewer should test that the package builds in mock. [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make %{?_smp_mflags} macro. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [?]: Package should not use obsolete m4 macros Note: Some obsoleted macros found, see the attachment. See: https://fedorahosted.org/FedoraReview/wiki/AutoTools [x]: Rpmlint is run on all installed packages. [-]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: cmockery2-1.3.4-1.fc21.armv7hl.rpm cmockery2-devel-1.3.4-1.fc21.armv7hl.rpm cmockery2-static-1.3.4-1.fc21.armv7hl.rpm cmockery2-1.3.4-1.fc21.src.rpm cmockery2.armv7hl: W: summary-ended-with-dot C Lightweight C unit testing framework. cmockery2.armv7hl: W: spelling-error %description -l en_US Cmockery -> Mockery, C mockery, Crockery cmockery2.armv7hl: W: spelling-error %description -l en_US executables -> executable, executable s, executrices cmockery2.armv7hl: W: no-version-in-last-changelog cmockery2.armv7hl: W: shared-lib-calls-exit /usr/lib/libcmockery.so.0.0.0 exit@GLIBC_2.4 cmockery2.armv7hl: E: library-without-ldconfig-postin /usr/lib/libcmockery.so.0.0.0 cmockery2.armv7hl: E: library-without-ldconfig-postun /usr/lib/libcmockery.so.0.0.0 cmockery2.armv7hl: W: devel-file-in-non-devel-package /usr/lib/libcmockery.so cmockery2-devel.armv7hl: W: summary-ended-with-dot C Lightweight C unit testing framework. cmockery2-devel.armv7hl: W: spelling-error %description -l en_US Cmockery -> Mockery, C mockery, Crockery cmockery2-devel.armv7hl: W: spelling-error %description -l en_US executables -> executable, executable s, executrices cmockery2-devel.armv7hl: W: no-version-in-last-changelog cmockery2-devel.armv7hl: E: zero-length /usr/share/doc/cmockery2-1.3.4/NEWS cmockery2-devel.armv7hl: W: install-file-in-docs /usr/share/doc/cmockery2-1.3.4/INSTALL cmockery2-static.armv7hl: W: summary-ended-with-dot C Lightweight C unit testing framework. cmockery2-static.armv7hl: W: spelling-error %description -l en_US Cmockery -> Mockery, C mockery, Crockery cmockery2-static.armv7hl: W: spelling-error %description -l en_US executables -> executable, executable s, executrices cmockery2-static.armv7hl: W: no-version-in-last-changelog cmockery2-static.armv7hl: W: no-documentation cmockery2.src: W: summary-ended-with-dot C Lightweight C unit testing framework. cmockery2.src: W: spelling-error %description -l en_US Cmockery -> Mockery, C mockery, Crockery cmockery2.src: W: spelling-error %description -l en_US executables -> executable, executable s, executrices cmockery2.src: W: no-version-in-last-changelog cmockery2.src: W: invalid-url Source0: cmockery2-1.3.4.tar.gz 4 packages and 0 specfiles checked; 3 errors, 21 warnings. AutoTools: Obsoleted m4s found ------------------------------ AC_PROG_LIBTOOL found in: cmockery2-1.3.4/configure.ac:31 AM_CONFIG_HEADER found in: cmockery2-1.3.4/configure.ac:22 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review