Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request:petitboot - graphical kexec-based bootloader https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=235409 jwboyer@xxxxxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From jwboyer@xxxxxxxxxxxxxxxxxx 2007-04-05 15:03 EST ------- Good must items: - rpmlint runs clean - meets naming guidelines - spec file matches base name - meets packaging guidelines - license field matches actual license - plain english, legible - source matches upstream - builds - dependencies in BuildRequires - no duplicate files - proper file permissions - proper macro use - contains appropriate %clean - no devel package - contains no .la files The license in the spec file is correct, however there are very few files that actually have a license header in them and a copy of the GPL is not included. I've emailed upstream myself about this so it can be fixed in future versions. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review