[Bug 1020839] Review Request: fedora-gooey-karma - GUI tool for adding karma to Bodhi system

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1020839



--- Comment #23 from Branislav Blaškovič <bblaskov@xxxxxxxxxx> ---
Spec URL:
http://blaskovic.fedorapeople.org/fedora-gooey-karma/fedora-gooey-karma.spec
SRPM URL:
http://blaskovic.fedorapeople.org/fedora-gooey-karma/fedora-gooey-karma-0.1-3.fc20.src.rpm

Copr: https://copr.fedoraproject.org/coprs/blaskovic/fedora-gooey-karma/builds/

Changes:
--------
* Fri Mar 14 2014 Branislav Blaskovic <branislav@xxxxxxxxxxxx> - 0.1-3
- Fixed UnicodeEncodeError issue #28
- Require for hicolor-icon-theme added
- Man page added

$ rpmlint ~/rpmbuild/SRPMS/fedora-gooey-karma-0.1-3.fc20.src.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

$ rpmlint ~/rpmbuild/RPMS/noarch/fedora-gooey-karma-0.1-3.fc20.noarch.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

I am not sure how to fix this:

[!]: Package must own all directories that it creates.
     Note: Directories without known owners:
     /usr/share/icons/hicolor/256x256/apps, /usr/share/icons/hicolor/24x24,
     /usr/share/icons/hicolor/32x32/apps, /usr/share/icons/hicolor/24x24/apps,
     /usr/share/icons/hicolor/16x16/apps, /usr/share/icons/hicolor/16x16,
     /usr/share/icons/hicolor/48x48, /usr/share/icons/hicolor/48x48/apps,
     /usr/share/icons/hicolor/256x256, /usr/share/icons/hicolor,
     /usr/share/icons/hicolor/32x32

I've added %{_datadir}/icons/hicolor/*/apps/ to %files. Is it correct solution?

fedora-review gives me:

[ ]: Package does not own files or directories owned by other packages.
     Note: Dirs in package are owned also by: 
     /usr/share/icons/hicolor/16x16/apps(mono-tools, hicolor-icon-theme,
     fedora-logos, anaconda), /usr/share/icons/hicolor/256x256/apps(mono-
     tools, hicolor-icon-theme, fedora-logos, anaconda),
     /usr/share/icons/hicolor/24x24/apps(mono-tools, hicolor-icon-theme,
     fedora-logos, anaconda), /usr/share/icons/hicolor/32x32/apps(mono-tools,
     hicolor-icon-theme, fedora-logos, anaconda),
     /usr/share/icons/hicolor/48x48/apps(mono-tools, hicolor-icon-theme,
     fedora-logos, anaconda)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]