[Bug 1075822] Review Request: openstack-marconi - OpenStack Message Queuing Service

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1075822

Stanislav Ochotnicky <sochotni@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sochotni@xxxxxxxxxx



--- Comment #1 from Stanislav Ochotnicky <sochotni@xxxxxxxxxx> ---
Few notes before Haïkel gets to this:
 1. Version is incorrect. Look at naming guidelines[1]. This seems like
post-release version situation. I'd strongly suggest packaging upstream
releases whenever possible
 2. Source0 URL doesn't exist (it seems almost as a joke...)
 3. There is no changelog
 4. Apache 2.0 requires full LICENSE text to be distributed with all
binary/source packages. You have to include it even if upstream doesn't (but
that should be fixed upstream eventually because they cause all redistributors
to fail their own license...)
 5. While you are at it packaging ChangeLog would be nice as well



[1]
https://fedoraproject.org/wiki/Packaging:NamingGuidelines?rd=Packaging/NamingGuidelines#Version_Tag

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]