https://bugzilla.redhat.com/show_bug.cgi?id=1074147 --- Comment #8 from Christopher Meng <cickumqt@xxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues: ======= - Package uses either %{buildroot} or $RPM_BUILD_ROOT Note: Using both %{buildroot} and $RPM_BUILD_ROOT See: http://fedoraproject.org/wiki/Packaging/Guidelines#macros ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "zlib/libpng", "Unknown or generated", "*No copyright* Public domain". 70 files have unknown license. Detailed output of licensecheck: *No copyright* Public domain ---------------------------- apt-cacher-ng-0.7.25/include/sha1.h apt-cacher-ng-0.7.25/source/sha1.cc Unknown or generated -------------------- apt-cacher-ng-0.7.25/client/client.cc apt-cacher-ng-0.7.25/dbgen/checkdebmirrors.sh apt-cacher-ng-0.7.25/dbgen/deburlgen.pl apt-cacher-ng-0.7.25/dbgen/gentoo_mirrors.sh apt-cacher-ng-0.7.25/dbgen/ubuntuscan.sh apt-cacher-ng-0.7.25/deprecated/checkenv.sh apt-cacher-ng-0.7.25/deprecated/debsplit.pl apt-cacher-ng-0.7.25/distkill.pl apt-cacher-ng-0.7.25/expire-caller.pl apt-cacher-ng-0.7.25/fs/httpfs.cc apt-cacher-ng-0.7.25/include/acbuf.h apt-cacher-ng-0.7.25/include/acfg.h apt-cacher-ng-0.7.25/include/aclogger.h apt-cacher-ng-0.7.25/include/bgtask.h apt-cacher-ng-0.7.25/include/cacheman.h apt-cacher-ng-0.7.25/include/caddrinfo.h apt-cacher-ng-0.7.25/include/cleaner.h apt-cacher-ng-0.7.25/include/config.h apt-cacher-ng-0.7.25/include/conn.h apt-cacher-ng-0.7.25/include/conserver.h apt-cacher-ng-0.7.25/include/csmapping.h apt-cacher-ng-0.7.25/include/debug.h apt-cacher-ng-0.7.25/include/dirwalk.h apt-cacher-ng-0.7.25/include/dlcon.h apt-cacher-ng-0.7.25/include/expiration.h apt-cacher-ng-0.7.25/include/fileio.h apt-cacher-ng-0.7.25/include/fileitem.h apt-cacher-ng-0.7.25/include/filereader.h apt-cacher-ng-0.7.25/include/header.h apt-cacher-ng-0.7.25/include/job.h apt-cacher-ng-0.7.25/include/lockable.h apt-cacher-ng-0.7.25/include/maintenance.h apt-cacher-ng-0.7.25/include/meta.h apt-cacher-ng-0.7.25/include/mirror.h apt-cacher-ng-0.7.25/include/pkgimport.h apt-cacher-ng-0.7.25/include/rfc2553emu.h apt-cacher-ng-0.7.25/include/showinfo.h apt-cacher-ng-0.7.25/include/sockio.h apt-cacher-ng-0.7.25/include/tcpconnect.h apt-cacher-ng-0.7.25/include/testdlopen.h apt-cacher-ng-0.7.25/include/testpthread.h apt-cacher-ng-0.7.25/include/testssl.h apt-cacher-ng-0.7.25/source/acbuf.cc apt-cacher-ng-0.7.25/source/acfg.cc apt-cacher-ng-0.7.25/source/acfg_defaults.cc apt-cacher-ng-0.7.25/source/aclogger.cc apt-cacher-ng-0.7.25/source/apt-cacher.cc apt-cacher-ng-0.7.25/source/bgtask.cc apt-cacher-ng-0.7.25/source/cacheman.cc apt-cacher-ng-0.7.25/source/caddrinfo.cc apt-cacher-ng-0.7.25/source/cleaner.cc apt-cacher-ng-0.7.25/source/conn.cc apt-cacher-ng-0.7.25/source/conserver.cc apt-cacher-ng-0.7.25/source/dirwalk.cc apt-cacher-ng-0.7.25/source/dlcon.cc apt-cacher-ng-0.7.25/source/expiration.cc apt-cacher-ng-0.7.25/source/fileio.cc apt-cacher-ng-0.7.25/source/fileitem.cc apt-cacher-ng-0.7.25/source/filereader.cc apt-cacher-ng-0.7.25/source/header.cc apt-cacher-ng-0.7.25/source/job.cc apt-cacher-ng-0.7.25/source/lockable.cc apt-cacher-ng-0.7.25/source/maintenance.cc apt-cacher-ng-0.7.25/source/meta.cc apt-cacher-ng-0.7.25/source/mirror.cc apt-cacher-ng-0.7.25/source/pkgimport.cc apt-cacher-ng-0.7.25/source/rfc2553emu.cc apt-cacher-ng-0.7.25/source/showinfo.cc apt-cacher-ng-0.7.25/source/tcpconnect.cc apt-cacher-ng-0.7.25/urlencode-fixer.pl zlib/libpng ----------- apt-cacher-ng-0.7.25/include/md5.h apt-cacher-ng-0.7.25/source/md5.cc [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [!]: %build honors applicable compiler flags or justifies otherwise. [!]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [!]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 81920 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Perl: [?]: Package contains the mandatory BuildRequires and Requires:. Note: Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version)) missing? ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Files in /run, var/run and /var/lock uses tmpfiles.d when appropriate [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make %{?_smp_mflags} macro. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: apt-cacher-ng-0.7.25-3.fc21.i686.rpm apt-cacher-ng-0.7.25-3.fc21.src.rpm apt-cacher-ng.i686: E: description-line-too-long C A caching proxy. Specialized for package files from Linux distributors, primarily for Debian (and Debian based) distributions. apt-cacher-ng.i686: W: only-non-binary-in-usr-lib apt-cacher-ng.i686: W: non-standard-uid /var/run/apt-cacher-ng apt-cacher-ng apt-cacher-ng.i686: W: non-standard-gid /var/run/apt-cacher-ng apt-cacher-ng apt-cacher-ng.i686: E: non-standard-dir-perm /var/run/apt-cacher-ng 0700L apt-cacher-ng.i686: W: non-standard-uid /var/lib/apt-cacher-ng apt-cacher-ng apt-cacher-ng.i686: W: non-standard-gid /var/lib/apt-cacher-ng apt-cacher-ng apt-cacher-ng.i686: E: non-standard-dir-perm /var/lib/apt-cacher-ng 0700L apt-cacher-ng.i686: W: non-standard-uid /var/cache/apt-cacher-ng apt-cacher-ng apt-cacher-ng.i686: W: non-standard-gid /var/cache/apt-cacher-ng apt-cacher-ng apt-cacher-ng.i686: E: non-standard-dir-perm /var/cache/apt-cacher-ng 0700L apt-cacher-ng.i686: W: non-standard-uid /var/log/apt-cacher-ng apt-cacher-ng apt-cacher-ng.i686: W: non-standard-gid /var/log/apt-cacher-ng apt-cacher-ng apt-cacher-ng.i686: E: non-standard-dir-perm /var/log/apt-cacher-ng 0700L apt-cacher-ng.i686: E: non-readable /etc/cron.daily/apt-cacher-ng 0750L apt-cacher-ng.i686: E: non-standard-executable-perm /etc/cron.daily/apt-cacher-ng 0750L apt-cacher-ng.i686: E: executable-marked-as-config-file /etc/cron.daily/apt-cacher-ng apt-cacher-ng.i686: W: dangling-relative-symlink /etc/apt-cacher-ng/backends_ubuntu.default ../../var/lib/apt-cacher-ng/backends_ubuntu.default apt-cacher-ng.i686: W: dangling-relative-symlink /etc/apt-cacher-ng/backends_debian.default ../../var/lib/apt-cacher-ng/backends_debian.default apt-cacher-ng.i686: E: non-executable-script /usr/libexec/apt-cacher-ng/expire-caller.pl 0644L /usr/bin/perl apt-cacher-ng.src: E: description-line-too-long C A caching proxy. Specialized for package files from Linux distributors, primarily for Debian (and Debian based) distributions. apt-cacher-ng.src:73: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 73) 2 packages and 0 specfiles checked; 10 errors, 12 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint apt-cacher-ng apt-cacher-ng.i686: E: description-line-too-long C A caching proxy. Specialized for package files from Linux distributors, primarily for Debian (and Debian based) distributions. apt-cacher-ng.i686: W: only-non-binary-in-usr-lib apt-cacher-ng.i686: W: non-standard-uid /var/run/apt-cacher-ng apt-cacher-ng apt-cacher-ng.i686: W: non-standard-gid /var/run/apt-cacher-ng apt-cacher-ng apt-cacher-ng.i686: E: non-standard-dir-perm /var/run/apt-cacher-ng 0700L apt-cacher-ng.i686: W: non-standard-uid /var/lib/apt-cacher-ng apt-cacher-ng apt-cacher-ng.i686: W: non-standard-gid /var/lib/apt-cacher-ng apt-cacher-ng apt-cacher-ng.i686: E: non-standard-dir-perm /var/lib/apt-cacher-ng 0700L apt-cacher-ng.i686: W: non-standard-uid /var/cache/apt-cacher-ng apt-cacher-ng apt-cacher-ng.i686: W: non-standard-gid /var/cache/apt-cacher-ng apt-cacher-ng apt-cacher-ng.i686: E: non-standard-dir-perm /var/cache/apt-cacher-ng 0700L apt-cacher-ng.i686: W: non-standard-uid /var/log/apt-cacher-ng apt-cacher-ng apt-cacher-ng.i686: W: non-standard-gid /var/log/apt-cacher-ng apt-cacher-ng apt-cacher-ng.i686: E: non-standard-dir-perm /var/log/apt-cacher-ng 0700L apt-cacher-ng.i686: E: non-readable /etc/cron.daily/apt-cacher-ng 0750L apt-cacher-ng.i686: E: non-standard-executable-perm /etc/cron.daily/apt-cacher-ng 0750L apt-cacher-ng.i686: E: executable-marked-as-config-file /etc/cron.daily/apt-cacher-ng apt-cacher-ng.i686: W: dangling-relative-symlink /etc/apt-cacher-ng/backends_ubuntu.default ../../var/lib/apt-cacher-ng/backends_ubuntu.default apt-cacher-ng.i686: W: dangling-relative-symlink /etc/apt-cacher-ng/backends_debian.default ../../var/lib/apt-cacher-ng/backends_debian.default apt-cacher-ng.i686: E: non-executable-script /usr/libexec/apt-cacher-ng/expire-caller.pl 0644L /usr/bin/perl 1 packages and 0 specfiles checked; 9 errors, 11 warnings. # echo 'rpmlint-done:' Requires -------- apt-cacher-ng (rpmlib, GLIBC filtered): /bin/sh /usr/bin/perl config(apt-cacher-ng) crontabs libbz2.so.1 libc.so.6 libdl.so.2 libgcc_s.so.1 libgcc_s.so.1(GCC_3.0) liblzma.so.5 liblzma.so.5(XZ_5.0) libpthread.so.0 libstdc++.so.6 libstdc++.so.6(CXXABI_1.3) libwrap.so.0 libz.so.1 logrotate perl(MIME::Base64) perl(Socket) perl(Sys::Hostname) perl(strict) rtld(GNU_HASH) systemd Provides -------- apt-cacher-ng: apt-cacher-ng apt-cacher-ng(x86-32) config(apt-cacher-ng) Source checksums ---------------- http://ftp.debian.org/debian/pool/main/a/apt-cacher-ng/apt-cacher-ng_0.7.25.orig.tar.xz : CHECKSUM(SHA256) this package : 736c65bc28123567a79b661267270aac0cfb579efff4daebfddc9b0764e3b432 CHECKSUM(SHA256) upstream package : 736c65bc28123567a79b661267270aac0cfb579efff4daebfddc9b0764e3b432 http://ftp.debian.org/debian/pool/main/a/apt-cacher-ng/apt-cacher-ng_0.7.25-1.debian.tar.xz : CHECKSUM(SHA256) this package : 6b5e0e35410ed2770e395b35d9dffedbb53e31e58fc0666ef95055c09e3b7168 CHECKSUM(SHA256) upstream package : 6b5e0e35410ed2770e395b35d9dffedbb53e31e58fc0666ef95055c09e3b7168 Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13 Command line :/usr/bin/fedora-review -rvn apt-cacher-ng-0.7.25-3.fc20.src.rpm Buildroot used: fedora-rawhide-i386 Active plugins: Generic, Shell-api, Perl Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG -------------------------------------- 1. [!]: %build honors applicable compiler flags or justifies otherwise. Building issues: i. -- Performing Test HAVE_SSL -- Performing Test HAVE_SSL - Failed OpenSSL not found or not working, disabling support Missing BuildRequires openssl-devel ii. -- Performing Test HAVE_BOOST_SMARTPTR -- Performing Test HAVE_BOOST_SMARTPTR - Failed Quoted from INSTALL: " - GCC and Boost headers (http://boost.org) OR GCC 4.x and its libstdc++ with header files OR a GCC compatible compiler and STL with C++-0x compliant smart pointers" You should add BR boost-devel. iii. cd build && cmake .. "-DCMAKE_CXX_FLAGS=-g -O3 -Wall" You can use "%cmake" to configure before building instead of "make %{?_smp_mflags}" directly, as the cxxflags and ldflags are not set properly. >From the gmake file shipped in xz, you can see ifneq ($(DEBUG),) CXXFLAGS += -g -O0 -DDEBUG CMAKEOPTS += -DADDDEBUGSRC=1 --debug-trycompile --debug-output endif ifneq ($(CXXFLAGS),) CMAKEOPTS += "-DCMAKE_CXX_FLAGS=$(CXXFLAGS)" else CMAKEOPTS += "-DCMAKE_CXX_FLAGS=-g -O3 -Wall" endif ifneq ($(LDFLAGS),) CMAKEOPTS += "-DCMAKE_EXE_LINKER_FLAGS=$(LDFLAGS)" endif Thus solutions: 1) make CXXFLAGS=%{optflags} LDFLAGS=%{__global_ldflags} %{?_smp_mflags} 2) mkdir build && cd build && %cmake .. make %{?_smp_mflags} 2. Quoted from INSTALL again: " - for apt clients, there is a config snipped in contrib/10-apt-cacher-ng.conf which might be installed into /etc/apt/apt.conf.d/." Have you tested it if it works as expected on Fedora? 3. This package contains a folder named systemd/, it includes sysconfig and systemd unit, you should use the one shipped in the tarball instead of using a patch. And you've forgotten the sysconfig file. 4. [!]: Package contains no bundled libraries without FPC exception. apt-cacher-ng-0.7.25/include/sha1.h apt-cacher-ng-0.7.25/source/sha1.cc copylib I think, but not granted exception in: https://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries like md5: https://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries#cite_note-0 So I think you need to file an fpc ticket. 5. zlib/libpng ----------- apt-cacher-ng-0.7.25/include/md5.h apt-cacher-ng-0.7.25/source/md5.cc Maybe this is a C++ port of Peter Deutsch's version, you need to add Provides: bundled(md5-deutsch-c++) But please double check by yourself. 6. apt-cacher-ng.i686: E: description-line-too-long C A caching proxy. Specialized for package files from Linux distributors, primarily for Debian (and Debian based) distributions. Remember 79 chars per line in %description. 7. apt-cacher-ng.i686: E: non-standard-executable-perm /etc/cron.daily/apt-cacher-ng 0750L apt-cacher-ng.i686: E: executable-marked-as-config-file /etc/cron.daily/apt-cacher-ng chmod -x, I think a configuration file doesn't need that. 8. apt-cacher-ng.i686: W: dangling-relative-symlink /etc/apt-cacher-ng/backends_ubuntu.default ../../var/lib/apt-cacher-ng/backends_ubuntu.default apt-cacher-ng.i686: W: dangling-relative-symlink /etc/apt-cacher-ng/backends_debian.default ../../var/lib/apt-cacher-ng/backends_debian.default You can ignore this, but please ensure they are correct ;) 9. apt-cacher-ng.i686: E: non-executable-script /usr/libexec/apt-cacher-ng/expire-caller.pl 0644L /usr/bin/perl Not 755? 10. - Package uses either %{buildroot} or $RPM_BUILD_ROOT Note: Using both %{buildroot} and $RPM_BUILD_ROOT See: http://fedoraproject.org/wiki/Packaging/Guidelines#macros You must give a choice ;) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review