https://bugzilla.redhat.com/show_bug.cgi?id=1074147 --- Comment #5 from Kenjiro Nakayama <knakayam@xxxxxxxxxx> --- (In reply to Christopher Meng from comment #4) Thanks. I updated. Updated Spec URL: http://diy-kenjiro.rhcloud.com/rpms/apt-cacher-ng.spec Updated SRPM URL: http://diy-kenjiro.rhcloud.com/rpms/apt-cacher-ng-0.7.25-3.fc20.src.rpm koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6631347 > 1. URL: http://packages.ubuntu.com/raring/apt-cacher-ng Updated. > 2. Its latest version is 0.7.25 via PTS: Updated. > 3. %description is shorter than %summary... You can do better... Updated both summary and description. > 4. rm -rf $RPM_BUILD_ROOT is not needed. Updated. > 5. install with -p to preserve the timestamp. Updated. > 6. gzip doc/man/*.8 > cp doc/man/*.8.gz $RPM_BUILD_ROOT%{_mandir}/man8/ Updated. > 7. Will you support EPEL5? If not remove everything related to it including conditional lines. Updated. (Removed, It's not neecessary to support EPEL5.) > 8. Cron jobs packaging guideline: > > https://fedoraproject.org/wiki/Packaging:CronFiles Update and also updated logrotate under the guideline. https://fedoraproject.org/wiki/User:Johannbg/Packaging/LogFiles#Logrotate_file -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review