[Bug 1063040] Review Request: rubygem-em-socksify - Transparent proxy support for any EventMachine protocol

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1063040



--- Comment #5 from Mo Morsi <mmorsi@xxxxxxxxxx> ---
Hey Nitesh a couple more things:

- You need to include the full url to the spec and srpm in your comment for the
fedora-review tool to pick it up (eg the srpm is missing 'http://'

- Since you are not running the test suite the BuildRequires: (eventmachine)
mentioned above can be omitted. Also you can remove the BuildRequires(rspec)
from the spec

- There is an extraneous %pushd in the %install section that should be removed

- The %{gem_spec} file should _not_ be excluded (necessary for the gem to work)

- The package should have a copy of the MIT license, see
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines#License_Text

Thanks

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]