https://bugzilla.redhat.com/show_bug.cgi?id=1071062 Christopher Meng <cickumqt@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review? --- Comment #1 from Christopher Meng <cickumqt@xxxxxxxxx> --- 1. # http://fedorapeople.org/~juanmabc/packages/doomsday/doomsday.spec # Juan Manuel Borges Caño is the original author of this file 404. You should point out these in changelog item. 2. %description: The Doomsday Engine is a greatly enhanced DOOM source port available for Windows, Mac OS X, Ubuntu and most other Unix platforms (source code is provided). Doomsday supports many games including the classic first-person shooters DOOM, Heretic and Hexen. Where is Fedora? Why can I only see the Crapuntu and Window$? IMO you need to improve the description, drop Windows, Mac, Ubuntu and Unix, they are completely nonsense here. 3. qmake-qt4 -r doomsday/doomsday.pro Please open your terminal and type: rpm -E %qmake_qt4 4. %post /sbin/ldconfig %postun -p /sbin/ldconfig Why don't you use %post -p /sbin/ldconfig? 5. %{_libdir}/lib*.so Where is the devel package? 6. BuildRequires: qt-devel Requires: qt Explicit requires, you add qt-devel for building, RPM will generate a dependencies list and store it in metadata, you won't need to specify this dependency again. 7. How did you find that Source0 URL? I can only find sf.net download link. 8. Where is snowberry? 9. BuildRequires: python-setuptools BuildRequires: python2-devel IMO they should be: BuildRequires: python2 And in fact snowberry requires the building via python, as pointed out in #8, I can't see it in the spec. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review